Messages in this thread | | | From | Aditya Garg <> | Subject | Re: [PATCH RESEND] media: uvcvideo: Add support for Apple T2-attached FaceTime HD Camera | Date | Thu, 3 Feb 2022 12:51:36 +0000 |
| |
> On 03-Feb-2022, at 5:29 AM, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > > Hi Aditya, > > On Wed, Feb 02, 2022 at 07:08:21AM +0000, Aditya Garg wrote: >>> On 02-Feb-2022, at 12:07 PM, Laurent Pinchart wrote: >>> On Wed, Jan 26, 2022 at 10:37:13AM +0000, Aditya Garg wrote: >>>> From: Paul Pawlowski <paul@mrarm.io> >>>> >>>> Adds the requisite device id to support detection of the Apple FaceTime >>>> HD webcam exposed over the T2 BCE VHCI interface. >>>> >>>> Tested-by: Aun-Ali Zaidi <admin@kodeit.net> >>>> Signed-off-by: Paul Pawlowski <paul@mrarm.io> >>>> Signed-off-by: Aun-Ali Zaidi <admin@kodeit.net> >>>> Signed-off-by: Aditya Garg <gargaditya08@live.com> >>>> --- >>>> drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++ >>>> 1 file changed, 9 insertions(+) >>>> >>>> diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c >>>> index 7c007426e..88dc9e7aa 100644 >>>> --- a/drivers/media/usb/uvc/uvc_driver.c >>>> +++ b/drivers/media/usb/uvc/uvc_driver.c >>>> @@ -2848,6 +2848,15 @@ static const struct usb_device_id uvc_ids[] = { >>>> .bInterfaceProtocol = 0, >>>> .driver_info = UVC_INFO_QUIRK(UVC_QUIRK_PROBE_MINMAX >>>> | UVC_QUIRK_BUILTIN_ISIGHT) }, >>>> + /* Apple FaceTime HD Camera (Built-In) */ >>>> + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE >>>> + | USB_DEVICE_ID_MATCH_INT_INFO, >>>> + .idVendor = 0x05ac, >>>> + .idProduct = 0x8514, >>>> + .bInterfaceClass = USB_CLASS_VIDEO, >>>> + .bInterfaceSubClass = 1, >>>> + .bInterfaceProtocol = 0, >>>> + .driver_info = (kernel_ulong_t)&uvc_quirk_probe_def }, >>> >>> Have you tested that the device doesn't work without this quirk ? >> >> uvcvideo 1-2:1.1: Failed to query (129) UVC probe control : -110 (exp. 48). >> uvcvideo 1-2:1.1: Failed to initialize the device (-5). >> >> These errors are encountered without this patch > > Thank you for the confirmation. > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > and applied to my tree. Thanks ! > >>>> /* Apple Built-In iSight via iBridge */ >>>> { .match_flags = USB_DEVICE_ID_MATCH_DEVICE >>>> | USB_DEVICE_ID_MATCH_INT_INFO, > > -- > Regards, > > Laurent Pinchart
| |