| Date | Thu, 3 Feb 2022 10:47:31 +0100 | Subject | Re: [PATCH v2 26/31] clk: mediatek: mtk: Implement error handling in register APIs | From | AngeloGioacchino Del Regno <> |
| |
Il 02/02/22 14:48, Chen-Yu Tsai ha scritto: > The remaining clk registration functions do not stop or return errors > if any clk failed to be registered, nor do they implement error > handling paths. This may result in a partially working device if any > step fails. > > Make the register functions return proper error codes, and bail out if > errors occur. Proper cleanup, i.e. unregister any clks that were > successfully registered, is done in the new error path. > > This also makes the |struct clk_data *| argument mandatory, as it is > used to track the list of clks registered. > > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > Reviewed-by: Miles Chen <miles.chen@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
|