Messages in this thread | | | From | Nick Desaulniers <> | Date | Thu, 3 Feb 2022 14:13:33 -0800 | Subject | Re: [PATCH 4/4 v5] fortify: Add Clang support |
| |
On Tue, Feb 1, 2022 at 4:30 PM Kees Cook <keescook@chromium.org> wrote: > > diff --git a/include/linux/fortify-string.h b/include/linux/fortify-string.h > index c45159dbdaa1..5482536d3197 100644 > --- a/include/linux/fortify-string.h > +++ b/include/linux/fortify-string.h > @@ -2,7 +2,9 @@ > #ifndef _LINUX_FORTIFY_STRING_H_ > #define _LINUX_FORTIFY_STRING_H_ > > -#define __FORTIFY_INLINE extern __always_inline __attribute__((gnu_inline)) > +#include <linux/const.h> > + > +#define __FORTIFY_INLINE extern __always_inline __attribute__((gnu_inline)) __overloadable
Sorry, I just noticed this line (already) uses a mix of open coding __attribute__ and not. Would you mind also please changing the open coded gnu_inline to simply __gnu_inline to make the entire line consistent? -- Thanks, ~Nick Desaulniers
| |