Messages in this thread | | | Date | Thu, 3 Feb 2022 21:30:28 +0000 | Subject | Re: [PATCH] media: i2c: Fix pixel array positions in ov8865 | From | Daniel Scally <> |
| |
Sorry all, missed media...let me resend this.
On 03/02/2022 21:23, Daniel Scally wrote: > The ov8865's datasheet gives the pixel array as 3296x2528, and the > active portion as the centre 3264x2448. This makes for a top offset > of 40 and a left offset of 16, not 32 and 80. > > Fixes: acd25e220921 ("media: i2c: Add .get_selection() support to ov8865") > > Reported-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com> > Signed-off-by: Daniel Scally <djrscally@gmail.com> > --- > drivers/media/i2c/ov8865.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/i2c/ov8865.c b/drivers/media/i2c/ov8865.c > index d9d016cfa9ac..53e21ae8e886 100644 > --- a/drivers/media/i2c/ov8865.c > +++ b/drivers/media/i2c/ov8865.c > @@ -457,8 +457,8 @@ > > #define OV8865_NATIVE_WIDTH 3296 > #define OV8865_NATIVE_HEIGHT 2528 > -#define OV8865_ACTIVE_START_TOP 32 > -#define OV8865_ACTIVE_START_LEFT 80 > +#define OV8865_ACTIVE_START_TOP 40 > +#define OV8865_ACTIVE_START_LEFT 16 > #define OV8865_ACTIVE_WIDTH 3264 > #define OV8865_ACTIVE_HEIGHT 2448 >
| |