Messages in this thread | | | From | "Kaliszczuk, Leszek" <> | Subject | RE: [PATCH] ice: Don't use GFP_KERNEL in atomic context | Date | Mon, 28 Feb 2022 15:07:33 +0000 |
| |
> -----Original Message----- > From: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > Sent: Sunday, January 16, 2022 7:46 PM > To: Brandeburg, Jesse <jesse.brandeburg@intel.com>; Nguyen, Anthony L > <anthony.l.nguyen@intel.com>; David S. Miller <davem@davemloft.net>; Jakub > Kicinski <kuba@kernel.org>; Saleem, Shiraz <shiraz.saleem@intel.com>; Ertman, > David M <david.m.ertman@intel.com> > Cc: linux-kernel@vger.kernel.org; kernel-janitors@vger.kernel.org; Christophe > JAILLET <christophe.jaillet@wanadoo.fr>; intel-wired-lan@lists.osuosl.org; > netdev@vger.kernel.org > Subject: [PATCH] ice: Don't use GFP_KERNEL in atomic context > > ice_misc_intr() is an irq handler. It should not sleep. > > Use GFP_ATOMIC instead of GFP_KERNEL when allocating some memory. > > Fixes: 348048e724a0 ("ice: Implement iidc operations") > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > I've never played a lot with irq handler. My understanding is that they should never > sleep. So GFP_KERNEL must be avoided. So I guess that this patch is correct. > > However, I don't know if some special cases allow such allocation. > Any feedback/pointer to a good doc/explanation is welcome :) > --- > drivers/net/ethernet/intel/ice/ice_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Tested-by: Leszek Kaliszczuk <leszek.kaliszczuk@intel.com>
| |