lkml.org 
[lkml]   [2022]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH V7 4/5] arm64: dts: qcom: pm8008: Add base dts file
From
Date

On 2/19/2022 7:27 AM, Stephen Boyd wrote:
> Quoting Satya Priya (2022-02-18 03:01:02)
>> Add base DTS file for pm8008 with infra and regulator nodes.
>>
>> Signed-off-by: Satya Priya <quic_c_skakit@quicinc.com>
>> ---
>> Changes in V4:
>> - This is newly added in V4, to add all the pm8008 common stuff.
>>
>> Changes in V5:
>> - Changed the mfd node names from pm8008_chip to pm8008_infra and
>> pm8008_ldo to pm8008_regulators as they re more appropriate.
>> - Changed the compatible for pm8008@9 mfd node to differentiate from
>> pm8008@8 node in driver.
>> - Removed compatible for regulators node.
>> - Removed reg property for LDOs and added in driver.
>>
>> Changes in V6:
>> - Changed node names to small letters.
>>
>> Changes in V7:
>> - Removed intermediate regulators node.
>>
>> arch/arm64/boot/dts/qcom/pm8008.dtsi | 44 ++++++++++++++++++++++++++++++++++++
>> 1 file changed, 44 insertions(+)
>> create mode 100644 arch/arm64/boot/dts/qcom/pm8008.dtsi
>>
>> diff --git a/arch/arm64/boot/dts/qcom/pm8008.dtsi b/arch/arm64/boot/dts/qcom/pm8008.dtsi
>> new file mode 100644
>> index 0000000..0f48572
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/qcom/pm8008.dtsi
>> @@ -0,0 +1,44 @@
>> +// SPDX-License-Identifier: BSD-3-Clause
>> +// Copyright (c) 2022, The Linux Foundation. All rights reserved.
>> +
>> +pm8008_infra: pm8008@8 {
> Node name should be generic, pmic@8


Okay.


>> + compatible = "qcom,pm8008";
>> + reg = <0x8>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +};
>> +
>> +pm8008_regulators: pm8008@9 {
> Node name should be generic, pmic@9


Okay.


>> + compatible = "qcom,pm8008-regulators";
>> + reg = <0x9>;
>> + #address-cells = <1>;
> Address cells is 0 too?


Okay.


>> + #size-cells = <0>;
>> +
>> + pm8008_l1: ldo1 {
>> + regulator-name = "pm8008_l1";
>> + };
>> +
>> + pm8008_l2: ldo2 {
>> + regulator-name = "pm8008_l2";
>> + };
>> +
>> + pm8008_l3: ldo3 {
>> + regulator-name = "pm8008_l3";
>> + };
>> +
>> + pm8008_l4: ldo4 {
>> + regulator-name = "pm8008_l4";
>> + };
>> +
>> + pm8008_l5: ldo5 {
>> + regulator-name = "pm8008_l5";
>> + };
>> +
>> + pm8008_l6: ldo6 {
>> + regulator-name = "pm8008_l6";
>> + };
>> +
>> + pm8008_l7: ldo7 {
>> + regulator-name = "pm8008_l7";
>> + };
>>

\
 
 \ /
  Last update: 2022-02-28 15:19    [W:1.396 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site