Messages in this thread | | | Date | Tue, 1 Mar 2022 10:43:47 +0800 | Subject | Re: [PATCH V3] tty: serial: meson: Fix the compile link error reported by kernel test robot | From | Yu Tu <> |
| |
Hi greg and dan, Thank you very much for your reply. I will make a separate submission as you suggested to fix Dan's suggestion.
On 2022/3/1 5:23, Greg Kroah-Hartman wrote: > [ EXTERNAL EMAIL ] > > On Mon, Feb 28, 2022 at 05:27:52PM +0300, Dan Carpenter wrote: >> On Mon, Feb 28, 2022 at 09:55:30PM +0800, Yu Tu wrote: >>> Describes the calculation of the UART baud rate clock using a clock >>> frame. Forgot to add in Kconfig kernel test Robot compilation error >>> due to COMMON_CLK dependency. >>> >>> Fixes: ("tty: serial:meson: Describes the calculation of the UART baud rate clock using a clock frame“) >>> Reported-by: kernel test robot <lkp@intel.com> >>> Reported-by: Dan Carpenter <dan.carpenter@oracle.com> >>> Signed-off-by: Yu Tu <yu.tu@amlogic.com> >>> --- >>> drivers/tty/serial/Kconfig | 1 + >>> drivers/tty/serial/meson_uart.c | 37 +++++++++++++++++++++++---------- >>> 2 files changed, 27 insertions(+), 11 deletions(-) >>> >>> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig >>> index e952ec5c7a7c..a0f2b82fc18b 100644 >>> --- a/drivers/tty/serial/Kconfig >>> +++ b/drivers/tty/serial/Kconfig >>> @@ -200,6 +200,7 @@ config SERIAL_KGDB_NMI >>> config SERIAL_MESON >>> tristate "Meson serial port support" >>> depends on ARCH_MESON || COMPILE_TEST >>> + depends on COMMON_CLK >>> select SERIAL_CORE >>> help >>> This enables the driver for the on-chip UARTs of the Amlogic >> >> >> This is a link issue. The rest is an unrelated error handling fix. >> It should really be sent as two patches. > > I'll take the first version of this patch, which just did this portion, > and the rest can be an independant change. > > thanks, > > greg k-h >
| |