lkml.org 
[lkml]   [2022]   [Feb]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH v2 0/2] drm/bridge: analogix_dp: Self-refresh state machine fixes
Date
Hi,

I've been investigating several eDP issues on a Rockchip RK3399 system
and have two proposed bugfixes. RK3399 has two CRTCs, either of which
can be used for eDP output. For both fixes, we have bugs due to the
relationship between the generalized "self refresh helpers" and the
analogix-dp bridge driver which controls much of the PSR mechanics.
These bugs are most visible when switching between CRTCs.

I'm not a DRM expert, but I've been poking at a lot of Rockchip display
drivers recently. I'd love some skeptical eyes, so feel free to ask
questions if I haven't explained issues well, or the proposals look
fishy.

Regards,
Brian

Changes in v2:
- Drop "->enable" condition in crtc_needs_disable(); this could possibly
be "->active" to reflect the intended hardware state, but it also is a
little over-specific. We want to make a transition through "disabled"
any time we're exiting PSR at the same time as a CRTC switch.
(Thanks Liu Ying)

Brian Norris (2):
drm/bridge: analogix_dp: Support PSR-exit to disable transition
drm/atomic: Force bridge self-refresh-exit on CRTC switch

.../drm/bridge/analogix/analogix_dp_core.c | 42 +++++++++++++++++--
drivers/gpu/drm/drm_atomic_helper.c | 16 +++++--
2 files changed, 51 insertions(+), 7 deletions(-)

--
2.35.1.574.g5d30c73bfb-goog

\
 
 \ /
  Last update: 2022-02-28 21:27    [W:2.140 / U:0.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site