lkml.org 
[lkml]   [2022]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH -next] misc: rtsx: fix build for CONFIG_PM not set
On Sat, Feb 26, 2022 at 11:24 PM Randy Dunlap <rdunlap@infradead.org> wrote:

> ---
> drivers/misc/cardreader/rtsx_pcr.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> --- linux-next-20220225.orig/drivers/misc/cardreader/rtsx_pcr.c
> +++ linux-next-20220225/drivers/misc/cardreader/rtsx_pcr.c
> @@ -1054,6 +1054,7 @@ static int rtsx_pci_acquire_irq(struct r
> return 0;
> }
>
> +#ifdef CONFIG_PM
> static void rtsx_enable_aspm(struct rtsx_pcr *pcr)
> {
> if (pcr->ops->set_aspm)
> @@ -1085,6 +1086,7 @@ static void rtsx_pm_power_saving(struct
> {
> rtsx_comm_pm_power_saving(pcr);
> }
> +#endif

Now that we have DEFINE_SIMPLE_DEV_PM_OPS() etc, I think we should
no longer add more __maybe_unused annotations or #ifdef CONFIG_PM checks
but just use the new macros for any new files or whenever a warning like
this shows up.

Arnd

\
 
 \ /
  Last update: 2022-02-27 13:05    [W:0.080 / U:0.276 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site