Messages in this thread | | | Date | Sat, 26 Feb 2022 12:13:39 -0800 | From | Luis Chamberlain <> | Subject | Re: [PATCH v3 2/2] fs/proc: Optimize arrays defined by struct ctl_path |
| |
On Thu, Feb 24, 2022 at 09:32:17PM +0800, Meng Tang wrote: > Previously, arrays defined by struct ctl_path is terminated > with an empty one. When we actually only register one ctl_path, > we've gone from 8 bytes to 16 bytes. > > The optimization has been implemented in the previous patch, > here to remove unnecessary terminate ctl_path with an empty one. > > Signed-off-by: Meng Tang <tangmeng@uniontech.com>
If these things are built-in, can you verify you're saving bytes with size before and after the patch?
I wonder if having something like DECLARE_SYSCTL_PATH_ONE() would make this nicer on the eyes, and also useful for the other changes you are making. Do you have many other single path entries you are changing later?
Luis
| |