Messages in this thread | | | Date | Sat, 26 Feb 2022 16:08:48 +0300 | Subject | Re: [PATCH] staging: pi433: prevent uninitialized data from being printed out | From | Pavel Skripkin <> |
| |
Hi Paulo Miguel,
On 2/26/22 07:25, Paulo Miguel Almeida wrote: > local_buffer is not initialised before data is passed to > spi_sync_transfer. In case spi* function fails then the dev_dbg > statement after that can potentially print out uninitialised data > > this patch initialises local_buffer array. > > Signed-off-by: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
I think, it should have a Fixes: tag.
> --- > Meta-comments: > > - this change was requested by Dan Carpenter in a different thread: > https://lore.kernel.org/lkml/20220207100601.GF1951@kadam/ >
Worth mentioning Dan with Reported-by/Suggested-by: :)
> Patch dependency: > > - this patch depends on the following patch to be applied first as > both of them change the same file: > https://lore.kernel.org/lkml/Yhla4a1Clpguoo2h@mail.google.com/ > ---
You can send all these patches as a patch series with proper order. It will help maintainers to not break the order while applying.
> drivers/staging/pi433/rf69.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c > index e5b23ab39c69..3028018f0b45 100644 > --- a/drivers/staging/pi433/rf69.c > +++ b/drivers/staging/pi433/rf69.c > @@ -782,7 +782,7 @@ int rf69_read_fifo(struct spi_device *spi, u8 *buffer, unsigned int size) > { > int i; > struct spi_transfer transfer; > - u8 local_buffer[FIFO_SIZE + 1]; > + u8 local_buffer[FIFO_SIZE + 1] = {}; > int retval; > > if (size > FIFO_SIZE) {
With regards, Pavel Skripkin
| |