| From | <> | Subject | Re: [PATCH v5 31/32] mtd: spi-nor: slightly change code style in spi_nor_sr_ready() | Date | Fri, 25 Feb 2022 14:08:41 +0000 |
| |
the subject should be mtd: spi-nor: core:
On 2/23/22 15:43, Michael Walle wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Now that there is almost no special case code left in > spi_nor_sr_ready(), the return check looks odd. Move the function call > closer to the return code checking. > > Signed-off-by: Michael Walle <michael@walle.cc> > Reviewed-by: Pratyush Yadav <p.yadav@ti.com> > --- > drivers/mtd/spi-nor/core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c > index f5a2f37d140e..9014008e60b3 100644 > --- a/drivers/mtd/spi-nor/core.c > +++ b/drivers/mtd/spi-nor/core.c > @@ -563,8 +563,9 @@ int spi_nor_write_ear(struct spi_nor *nor, u8 ear) > */ > int spi_nor_sr_ready(struct spi_nor *nor) > { > - int ret = spi_nor_read_sr(nor, nor->bouncebuf); > + int ret; > > + ret = spi_nor_read_sr(nor, nor->bouncebuf); > if (ret) > return ret; > > -- > 2.30.2 >
|