Messages in this thread | | | Date | Fri, 25 Feb 2022 14:04:26 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH v2 21/39] x86/ibt: Annotate text references |
| |
On Thu, Feb 24, 2022 at 04:47:16PM -0800, Josh Poimboeuf wrote: > On Thu, Feb 24, 2022 at 03:51:59PM +0100, Peter Zijlstra wrote: > > @@ -563,12 +564,14 @@ SYM_CODE_END(\asmsym) > > .align 16 > > .globl __irqentry_text_start > > __irqentry_text_start: > > + ANNOTATE_NOENDBR // unwinders > > But the instruction here (first idt entry) actually does have an > endbr64... > > Also I'm wondering if it would make sense to create an > 'idt_entry_<vector>' symbol for each entry so objtool knows to validate > their ENDBRs.
I think we're good on that front since irq_entries_start and spurious_entries_start capture the first entry and the rest is .rept off of that.
| |