Messages in this thread | | | Date | Fri, 25 Feb 2022 13:22:37 +0100 | Subject | Re: [PATCH 1/5] thermal: tegra-bpmp: Handle errors in BPMP response | From | Daniel Lezcano <> |
| |
On 07/10/2021 20:20, Thierry Reding wrote: > On Wed, Sep 15, 2021 at 11:55:13AM +0300, Mikko Perttunen wrote: >> The return value from tegra_bpmp_transfer indicates the success or >> failure of the IPC transaction with BPMP. If the transaction >> succeeded, we also need to check the actual command's result code. >> Add code to do this. >> >> Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com> >> --- >> drivers/thermal/tegra/tegra-bpmp-thermal.c | 13 ++++++++++++- >> 1 file changed, 12 insertions(+), 1 deletion(-) > > Perhaps this should be moved into tegra_bpmp_transfer() or some new > helper to make sure we can keep this consistent across all callers. > > For instance, I'm not sure -EINVAL is the right (or best) error code in > all the cases. Either way, seems fine in this case and this is certainly > an improvement, so: > > Acked-by: Thierry Reding <treding@nvidia.com>
Applied, thanks
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |