lkml.org 
[lkml]   [2022]   [Feb]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 12/39] x86/ibt,ftrace: Search for __fentry__ location
On Thu, 24 Feb 2022 21:19:19 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Fri, 25 Feb 2022 10:34:49 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > > > > + if (!rec) {
> > > > > + if (!kallsyms_lookup_size_offset(ip, &size, &offset))
> > > > > + goto out;
> > > > > +
> > > > > + if (!offset)
> > > >
> > > > Isn't this 'if (offset)' ?
> > >
> > > No, the point to only look for the fentry location if the ip passed in
> > > points to the start of the function. IOW, +0 offset.
> >
> > OK, so this means ftrace_location() will be same as
> > ftrace_location_range(sym, sym_end) ?
>
> No. It only acts like ftrace_location_range(sym, sym_end) if the passed
> in argument is the ip of the function (kallsyms returns offset = 0)

Got it. So now ftrace_location() will return the ftrace address
when the ip == func or ip == mcount-call.

Thank you,

--
Masami Hiramatsu <mhiramat@kernel.org>

\
 
 \ /
  Last update: 2022-02-25 11:21    [W:0.146 / U:0.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site