Messages in this thread | | | From | Miguel Ojeda <> | Date | Fri, 25 Feb 2022 21:47:19 +0100 | Subject | Re: [PATCH] [PATCH v2] AARCH64: Add gcc Shadow Call Stack support |
| |
On Fri, Feb 25, 2022 at 4:24 AM Dan Li <ashimida@linux.alibaba.com> wrote: > > + - Clang (https://clang.llvm.org/docs/ShadowCallStack.html) > + - GCC (https://gcc.gnu.org/onlinedocs/gcc/Instrumentation-Options.html#Instrumentation-Options)
Maybe Clang: and GCC: instead of the parenthesis?
> +#ifdef CONFIG_SHADOW_CALL_STACK > +#define __noscs __attribute__((__no_sanitize__("shadow-call-stack"))) > +#endif
Since both compilers have it, and I guess the `#ifdef` condition would work for both, could this be moved into `compiler_types.h` where the empty `__noscs` definition is, and remove the one from `compiler-clang.h`?
Cheers, Miguel
| |