Messages in this thread | | | Date | Fri, 25 Feb 2022 00:56:02 +0700 | Subject | Re: [PATCH] ASoC: SOF: Intel: Fix NULL ptr dereference when ENOMEM | From | Ammar Faizi <> |
| |
On 2/25/22 12:26 AM, Mark Brown wrote: > On Thu, Feb 24, 2022 at 09:51:24PM +0700, Ammar Faizi wrote: >> From: Ammar Faizi <ammarfaizi2@gnuweeb.org> >> >> Do not call snd_dma_free_pages() when snd_dma_alloc_pages() returns >> -ENOMEM because it leads to a NULL pointer dereference bug. >> >> The dmesg says: >> >> <6>[109482.497835][T138537] usb 1-2: Manufacturer: SIGMACHIP >> <6>[109482.502506][T138537] input: SIGMACHIP USB Keyboard as /devices/pci0000:00/0000:00:14.0/usb1/1-2/1-2:1.0/0003:1C4F:0002.000D/input/input34 >> <6>[109482.558976][T138537] hid-generic 0003:1C4F:0002.000D: input,hidraw1: USB HID v1.10 Keyboard [SIGMACHIP USB Keyboard] on usb-0000:00:14.0-2/input0 >> <6>[109482.561653][T138537] input: SIGMACHIP USB Keyboard Consumer Control as /devices/pci0000:00/0000:00:14.0/usb1/1-2/1-2:1.1/0003:1C4F:0002.000E/input/input35 > > Please think hard before including complete backtraces in upstream > reports, they are very large and contain almost no useful information > relative to their size so often obscure the relevant content in your > message. If part of the backtrace is usefully illustrative (it often is > for search engines if nothing else) then it's usually better to pull out > the relevant sections.
I will strip the irrelevant information in the v2.
-- Ammar Faizi
| |