Messages in this thread | | | Date | Thu, 24 Feb 2022 17:49:18 +0100 | From | Uwe Kleine-König <> | Subject | Re: [PATCH 1/3] pwm-sun4i: convert "next_period" to local variable |
| |
On Thu, Feb 24, 2022 at 02:04:23PM +0100, Thierry Reding wrote: > On Tue, Jan 25, 2022 at 03:31:58PM +0100, Uwe Kleine-König wrote: > > Hello, > > > > On Tue, Jan 25, 2022 at 01:34:27PM +0100, Max Kellermann wrote: > > > Its value is calculated in sun4i_pwm_apply() and is used only there. > > > > > > Cc: stable@vger.kernel.org > > > > I think I'd drop this. This isn't a fix worth on it's own to be > > backported and if this is needed for one of the next patches, the stable > > maintainers will notice themselves (and it might be worth to shuffle > > this series to make the fixes come first). > > > > > Signed-off-by: Max Kellermann <max.kellermann@gmail.com> > > > > Other than that, LGTM: > > > > Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > Does that apply to patches 2 & 3 as well?
No, at that time I only looked at patch 1.
I just looked at 2 and 3 and will reply to them individually.
Best regards Uwe
-- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |