Messages in this thread | | | Date | Thu, 24 Feb 2022 17:38:03 +0100 | From | Thierry Reding <> | Subject | Re: [PATCH 2/5] tty: serial: make use of UART_LCR_WLEN() + tty_get_char_size() |
| |
On Thu, Feb 24, 2022 at 10:55:55AM +0100, Jiri Slaby wrote: > Having a generic UART_LCR_WLEN() macro and the tty_get_char_size() > helper, we can remove all those repeated switch-cases in drivers. > > Signed-off-by: Jiri Slaby <jslaby@suse.cz> > Cc: Laxman Dewangan <ldewangan@nvidia.com> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Jonathan Hunter <jonathanh@nvidia.com> > Cc: linux-tegra@vger.kernel.org > --- > drivers/tty/serial/8250/8250_omap.c | 16 +--------------- > drivers/tty/serial/8250/8250_port.c | 16 +--------------- > drivers/tty/serial/jsm/jsm_cls.c | 16 +--------------- > drivers/tty/serial/jsm/jsm_neo.c | 16 +--------------- > drivers/tty/serial/omap-serial.c | 16 +--------------- > drivers/tty/serial/pxa.c | 16 +--------------- > drivers/tty/serial/serial-tegra.c | 22 ++++------------------ > drivers/tty/serial/vr41xx_siu.c | 15 +-------------- > 8 files changed, 11 insertions(+), 122 deletions(-)
This would've been easier to review if I had this in my inbox, but I did find it on lkml.org and this does look correct, so:
Reviewed-by: Thierry Reding <treding@nvidia.com> [unhandled content-type:application/pgp-signature] | |