Messages in this thread | | | Date | Thu, 24 Feb 2022 07:48:30 -0800 | Subject | Re: [PATCH v1 0/6] Add TDX Guest Attestation support | From | Sathyanarayanan Kuppuswamy <> |
| |
On 2/24/22 7:32 AM, Hans de Goede wrote: >> Patch titled "platform/x86: intel_tdx_attest: Add TDX Guest attestation >> interface driver" adds the attestation driver support. This is supposed >> to be reviewed by platform-x86 maintainers. > At a quick glance this looks ok to me, but I really know very little > about TDX. I assume the rest of the series will be reviewed by someone > with more detailed knowledge of TDX as such I believe it would be good > if the platform/x86 patch is also reviewed as part of that. > > Since the platform/x86 patch depends on the other patches I believe > it is also best if the entire series is merged in one go by the x86/tip > maintainers here is my ack for this: > > Acked-by: Hans de Goede<hdegoede@redhat.com>
Thanks.
> >> Also, patch titled "tools/tdx: Add a sample attestation user app" adds >> a testing app for attestation feature which needs review from >> bpf@vger.kernel.org. > I think that tool should be moved to tools/arch/x86/tdx regardless of > moving it, tools are typically reviewed together with the kernel side > and this has nothing to do with bpf.
I am fine with moving it to tools/arch/x86/*. I will do it in next version. I have included bpf because this is what I got out of ./scripts/get_maintainer.pl.
> > Regards, > > Hans >
-- Sathyanarayanan Kuppuswamy Linux Kernel Developer
| |