Messages in this thread |  | | Subject | Re: [PATCH 2/2] wireless: Initial driver submission for pureLiFi STA devices | From | Kalle Valo <> | Date | Thu, 24 Feb 2022 15:35:23 +0000 (UTC) |
| |
Srinivasan Raju <srini.raju@purelifi.com> wrote:
> This driver implementation has been based on the zd1211rw driver > > Driver is based on 802.11 softMAC Architecture and uses > native 802.11 for configuration and management > > The driver is compiled and tested in ARM, x86 architectures and > compiled in powerpc architecture > > Signed-off-by: Srinivasan Raju <srini.raju@purelifi.com>
I was about to take this to wireless-next but found few issues still:
o rename these to include plfxlc_ prefix:
int download_fpga(struct usb_interface *intf) int download_xl_firmware(struct usb_interface *intf) int plf_usb_wreq(void *buffer, int buffer_len, void tx_urb_complete(struct urb *urb) struct firmware_file { #define urb_dev(urb) (&(urb)->dev->dev) int plf_usb_wreq_async(struct plfxlc_usb *usb, const u8 *buffer, int plf_usb_wreq(void *buffer, int buffer_len,
* non-const global variable in usb.c, doesn't that prevent supporting multiple devices on the same host? It should be stored into a dynamically allocated location like struct plfxlc_usb.
struct usb_interface *ez_usb_interface;
* unused workqueue:
static struct workqueue_struct *plfxlc_workqueue;
-- https://patchwork.kernel.org/project/linux-wireless/patch/20211031131122.275386-3-srini.raju@purelifi.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
|  |