lkml.org 
[lkml]   [2022]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v1 1/1] IB/hfi1: Don't cast parameter in bit operations
From
On 2/23/22 4:44 PM, David Laight wrote:
> From: Andy Shevchenko
>> Sent: 23 February 2022 18:54
>>
>> While in this particular case it would not be a (critical) issue,
>> the pattern itself is bad and error prone in case somebody blindly
>> copies to their code.
>
> It is horribly wrong on BE systems.

Note that this driver has in Kconfig: depends on X86_64.
However it's a good point about not wanting anyone to blindly copy.

-Denny

\
 
 \ /
  Last update: 2022-02-24 14:40    [W:0.115 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site