Messages in this thread | | | Date | Thu, 24 Feb 2022 14:51:22 +0900 | Subject | Re: [PATCH -next] scsi: megasas: clean up some inconsistent indenting | From | Damien Le Moal <> |
| |
On 2/24/22 09:47, Yang Li wrote: > Eliminate the follow smatch warning: > drivers/scsi/megaraid/megaraid_sas_fusion.c:5104 megasas_reset_fusion() > warn: inconsistent indenting > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > drivers/scsi/megaraid/megaraid_sas_fusion.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi/megaraid/megaraid_sas_fusion.c > index c72364864bf4..aab600ef4cd6 100644 > --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c > +++ b/drivers/scsi/megaraid/megaraid_sas_fusion.c > @@ -5101,8 +5101,8 @@ int megasas_reset_fusion(struct Scsi_Host *shost, int reason) > for (j = 0; j < MAX_LOGICAL_DRIVES_EXT; ++j) { > memset(fusion->stream_detect_by_ld[j], > 0, sizeof(struct LD_STREAM_DETECT));
While at it, you could fix this weird indentation too.
> - fusion->stream_detect_by_ld[j]->mru_bit_map > - = MR_STREAM_BITMAP; > + fusion->stream_detect_by_ld[j]->mru_bit_map > + = MR_STREAM_BITMAP;
Still inconsistent: missing one tab, no ?
> } > }
Given the depth of the indentation, this initialization loop could go into a little inline helper function.
-- Damien Le Moal Western Digital Research
| |