lkml.org 
[lkml]   [2022]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5/5] irqchip/qcom-pdc: Drop open coded version of __assign_bit()
    Date
    The driver uses what looks like an open-coded version of __assign_bit().
    Replace it with the real thing.

    Signed-off-by: Marc Zyngier <maz@kernel.org>
    ---
    drivers/irqchip/qcom-pdc.c | 7 ++-----
    1 file changed, 2 insertions(+), 5 deletions(-)

    diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c
    index 0cd20ddfae2a..d96916cf6a41 100644
    --- a/drivers/irqchip/qcom-pdc.c
    +++ b/drivers/irqchip/qcom-pdc.c
    @@ -23,9 +23,6 @@

    #define PDC_MAX_GPIO_IRQS 256

    -#define CLEAR_INTR(reg, intr) (reg & ~(1 << intr))
    -#define ENABLE_INTR(reg, intr) (reg | (1 << intr))
    -
    #define IRQ_ENABLE_BANK 0x10
    #define IRQ_i_CFG 0x110

    @@ -55,16 +52,16 @@ static u32 pdc_reg_read(int reg, u32 i)
    static void pdc_enable_intr(struct irq_data *d, bool on)
    {
    int pin_out = d->hwirq;
    + unsigned long enable;
    unsigned long flags;
    u32 index, mask;
    - u32 enable;

    index = pin_out / 32;
    mask = pin_out % 32;

    raw_spin_lock_irqsave(&pdc_lock, flags);
    enable = pdc_reg_read(IRQ_ENABLE_BANK, index);
    - enable = on ? ENABLE_INTR(enable, mask) : CLEAR_INTR(enable, mask);
    + __assign_bit(mask, &enable, on);
    pdc_reg_write(IRQ_ENABLE_BANK, index, enable);
    raw_spin_unlock_irqrestore(&pdc_lock, flags);
    }
    --
    2.30.2
    \
     
     \ /
      Last update: 2022-02-24 11:14    [W:4.032 / U:0.248 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site