lkml.org 
[lkml]   [2022]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] m68k: Implement "current_stack_pointer"
Hi David, Kees,

On Thu, Feb 24, 2022 at 10:54 AM David Laight <David.Laight@aculab.com> wrote:
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> > Sent: 24 February 2022 09:17
> >
> > On Thu, Feb 24, 2022 at 10:12 AM David Laight <David.Laight@aculab.com> wrote:
> > > From: Geert Uytterhoeven
> > > > Sent: 24 February 2022 08:59
> > > ...
> > > > > +register unsigned long current_stack_pointer __asm__("sp");
> > > >
> > > > I don't know what HARDENED_USERCOPY does, so I don't know if you need
> > > > "usp" (see rdusp()) or "sp"?
> > >
> > > HARDENED_USERCOPY significantly slows down some systems calls
> > > (especially things like sendmsg()) by trying to run-time verify
> > > that the kernel buffer doesn't overrun a stack frame or kmalloc()ed
> >
> > Kernel stack frame of user stack frame?
>
> Kernel, the kernel doesn't care if the user stack gets trashed.

OK.

Reviewed-by: Geert Uytterhoeven <geert@linux-m68k.org>

Kees: Do you want me to queue this in the m68k for-v5.18 branch, or do
you want to take it yourself, together with the HARDENED_USERCOPY work?
In case of the latter:
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

Please let me know. Thanks!

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

\
 
 \ /
  Last update: 2022-02-24 10:57    [W:0.076 / U:1.448 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site