lkml.org 
[lkml]   [2022]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 08/11] iommu/vt-d: Fix indentation of goto labels
From
On 2/24/22 9:08 PM, Jason Gunthorpe wrote:
> On Mon, Feb 14, 2022 at 10:57:01AM +0800, Lu Baolu wrote:
>> Remove blanks before goto labels.
>>
>> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
>> drivers/iommu/intel/iommu.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> It would be better to rework this function to not have the goto
> spaghetti in the first place.. Looks like putting the
> 'for_each_active_dev_scope' into another function would do the trick.

Good idea. Let me revisit this later.

>
> Anyhow, this is more consistent with kernel style:
>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
>
> Jason

Best regards,
baolu

\
 
 \ /
  Last update: 2022-02-25 02:59    [W:0.101 / U:0.856 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site