lkml.org 
[lkml]   [2022]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] clk: lan966x: Depend on CONFIG_IOMEM
From
Date
Quoting David Gow (2022-02-23 19:59:02)
> The lan966x clk driver depends on IOMEM functions, in particular
> devm_platform_ioremap_resource(), but doesn't state a formal dependency
> on it in Kconfig.
>
> Add such a dependency, which prevents this driver from being enabled
> on UML configurations without IOMEM.
>
> This fixes the following build failure:
>
> /usr/bin/ld: drivers/clk/clk-lan966x.o: in function `lan966x_clk_probe':
> clk-lan966x.c:(.text+0x294): undefined reference to `devm_platform_ioremap_resource'
> /usr/bin/ld: clk-lan966x.c:(.text+0x3aa): undefined reference to `devm_ioremap_resource'
> collect2: error: ld returned 1 exit status
>
> Signed-off-by: David Gow <davidgow@google.com>
> ---
> drivers/clk/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
> index 3cdf33470a75..7b5db8a9eb4f 100644
> --- a/drivers/clk/Kconfig
> +++ b/drivers/clk/Kconfig
> @@ -231,6 +231,7 @@ config COMMON_CLK_GEMINI
>
> config COMMON_CLK_LAN966X
> bool "Generic Clock Controller driver for LAN966X SoC"
> + depends on IOMEM

What is CONFIG_IOMEM? This is superseded by
https://lore.kernel.org/r/20220219141536.460812-1-horatiu.vultur@microchip.com

> help
> This driver provides support for Generic Clock Controller(GCK) on
> LAN966X SoC. GCK generates and supplies clock to various peripherals

\
 
 \ /
  Last update: 2022-02-25 01:56    [W:0.105 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site