lkml.org 
[lkml]   [2022]   [Feb]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 12/39] x86/ibt,ftrace: Search for __fentry__ location
On Thu, 24 Feb 2022 14:46:31 -0800
Josh Poimboeuf <jpoimboe@redhat.com> wrote:

> > > > > + rec = lookup_rec(ip - offset, (ip - offset) + size);
>
> If 'offset' is zero then why the math here? ^^^^^^^^^^^ ^^^^^^^^^^^

Because it didn't check for offset being zero when we wrote that line. ;-)

Yes, checking for !offset makes that logic irrelevant.

Good catch.

-- Steve

\
 
 \ /
  Last update: 2022-02-24 23:52    [W:0.201 / U:1.560 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site