Messages in this thread | | | Date | Thu, 24 Feb 2022 17:51:41 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH v2 12/39] x86/ibt,ftrace: Search for __fentry__ location |
| |
On Thu, 24 Feb 2022 14:46:31 -0800 Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> > > > > + rec = lookup_rec(ip - offset, (ip - offset) + size); > > If 'offset' is zero then why the math here? ^^^^^^^^^^^ ^^^^^^^^^^^
Because it didn't check for offset being zero when we wrote that line. ;-)
Yes, checking for !offset makes that logic irrelevant.
Good catch.
-- Steve
| |