Messages in this thread | | | Date | Thu, 24 Feb 2022 23:39:08 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH AUTOSEL 5.16 24/30] dmaengine: shdma: Fix runtime PM imbalance on error |
| |
Hi!
> From: Yongzhi Liu <lyz_cs@pku.edu.cn> > > [ Upstream commit 455896c53d5b803733ddd84e1bf8a430644439b6 ] > > pm_runtime_get_() increments the runtime PM usage counter even > when it returns an error code, thus a matching decrement is needed on > the error handling path to keep the counter balanced.
I don't think that's right.
Notice that -ret is ignored (checked 4.4 and 5.10), so we don't actually abort/return error; we just printk. We'll do two pm_runtime_put's after the "fix".
Please drop from -stable.
Best regards, Pavel -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany [unhandled content-type:application/pgp-signature] | |