Messages in this thread | | | Date | Thu, 24 Feb 2022 22:02:26 +0000 | From | Matthew Wilcox <> | Subject | Re: [PATCH -next] mm/rmap: Fix argument list that the kdoc format and script verified. |
| |
On Thu, Feb 24, 2022 at 09:43:44AM +0800, Yang Li wrote: > The warnings were found by running scripts/kernel-doc, which is > caused by using 'make W=1'. > > mm/rmap.c:1684: warning: Function parameter or member 'folio' not > described in 'try_to_unmap' > mm/rmap.c:1684: warning: Excess function parameter 'page' description in > 'try_to_unmap'
Fixed these like this instead:
/** - * try_to_unmap - try to remove all page table mappings to a page - * @page: the page to get unmapped + * try_to_unmap - Try to remove all page table mappings to a folio. + * @folio: The folio to unmap. * @flags: action and flags * * Tries to remove all the page table entries which are mapping this - * page, used in the pageout path. Caller must hold the page lock. + * folio. It is the caller's responsibility to check if the folio is + * still mapped if needed (use TTU_SYNC to prevent accounting races). * - * It is the caller's responsibility to check if the page is still - * mapped when needed (use TTU_SYNC to prevent accounting races). + * Context: Caller must hold the folio lock. */
| |