lkml.org 
[lkml]   [2022]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 07/18] KVM: x86/mmu: Do not use guest root level in audit
From
Date
On Fri, 2022-02-18 at 19:46 +0100, Paolo Bonzini wrote:
> On 2/18/22 19:37, Sean Christopherson wrote:
> > Since I keep bringing it up...
> >
> > From: Sean Christopherson<seanjc@google.com>
> > Date: Fri, 18 Feb 2022 09:43:05 -0800
> > Subject: [PATCH] KVM: x86/mmu: Remove MMU auditing
> >
> > Remove mmu_audit.c and all its collateral, the auditing code has suffered
> > severe bitrot, ironically partly due to shadow paging being more stable
> > and thus not benefiting as much from auditing, but mostly due to TDP
> > supplanting shadow paging for non-nested guests and shadowing of nested
> > TDP not heavily stressing the logic that is being audited.
> >
> > Signed-off-by: Sean Christopherson<seanjc@google.com>
>
> Queued, thanks. O:-)

I once kind of played with it.

Note that shadow mmu does have bugs - I can easily crash L1/L2 when
doing repeated migrations when I disable NPT either in L0 or L1,
and when I force the mmu to be always sync (see my strict_mmu patch),
the crashes go away.

mmu audit maybe could have helped with that.

But I won't argue too much about this.

Best regards,
Maxim Levitsky

>
> Paolo
>


\
 
 \ /
  Last update: 2022-02-23 16:03    [W:0.093 / U:1.776 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site