lkml.org 
[lkml]   [2022]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/3] KVM: SVM: fix race between interrupt delivery and AVIC inhibition
From
Date
On Fri, 2022-02-11 at 17:35 +0000, Sean Christopherson wrote:
> On Fri, Feb 11, 2022, Paolo Bonzini wrote:
> > On 2/11/22 18:11, Sean Christopherson wrote:
> > > > + /* Process the interrupt with a vmexit. */
> > >
> > > Double spaces at the end. But I would prefer we omit the comment entirely,
> > > there is no guarantee the vCPU is in the guest or even running.
> >
> > Sure, or perhaps "process the interrupt in inject_pending_event".
>
> s/in/via?
>
> > Regarding the two spaces, it used to a pretty strict rule in the US with
> > typewriters. It helps readability of monospaced fonts
> > (https://www.cultofpedagogy.com/two-spaces-after-period/), and code is
> > mostly monospaced... But well, the title of the article says it all.
>
> Preaching to the choir, I'm a firm believer that there should always be two spaces
> after a full stop, monospace or not. Unless it's the end of a comment. :-D
>
As someone who gotten into typewritter repair hobby lately, I sure understand what you mean.
But for some reason I still use one space after period even on a typewritter and
that doesn't bother me :-)

Best regards,
Maxim Levitsky

\
 
 \ /
  Last update: 2022-02-23 13:16    [W:0.048 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site