Messages in this thread | | | Date | Wed, 23 Feb 2022 10:11:26 +0100 | From | Peter Zijlstra <> | Subject | Re: [PATCH v3 1/3] sched/cpuacct: fix charge percpu cpuusage |
| |
On Tue, Feb 22, 2022 at 08:01:51AM -1000, Tejun Heo wrote: > On Sun, Feb 20, 2022 at 01:14:24PM +0800, Chengming Zhou wrote: > > The cpuacct_account_field() is always called by the current task > > itself, so it's ok to use __this_cpu_add() to charge the tick time. > > > > But cpuacct_charge() maybe called by update_curr() in load_balance() > > on a random CPU, different from the CPU on which the task is running. > > So __this_cpu_add() will charge that cputime to a random incorrect CPU. > > > > Fixes: 73e6aafd9ea8 ("sched/cpuacct: Simplify the cpuacct code") > > Reported-by: Minye Zhu <zhuminye@bytedance.com> > > Signed-off-by: Chengming Zhou <zhouchengming@bytedance.com> > > For all three patches, > > Acked-by: Tejun Heo <tj@kernel.org>
Thanks!
| |