Messages in this thread | | | Date | Wed, 23 Feb 2022 15:53:42 -0600 | From | Bjorn Helgaas <> | Subject | Re: [PATCH v2 01/11] driver: platform: add and use helper for safer setting of driver_override |
| |
On Wed, Feb 23, 2022 at 08:13:00PM +0100, Krzysztof Kozlowski wrote: > Several core drivers and buses expect that driver_override is a > dynamically allocated memory thus later they can kfree() it. > ...
> + * set_driver_override() - Helper to set or clear driver override.
Doesn't match actual function name.
> + * @dev: Device to change > + * @override: Address of string to change (e.g. &device->driver_override); > + * The contents will be freed and hold newly allocated override. > + * @s: NULL terminated string, new driver name to force a match, pass empty > + * string to clear it > + * > + * Helper to setr or clear driver override in a device, intended for the cases > + * when the driver_override field is allocated by driver/bus code.
s/setr/set/
> + * Returns: 0 on success or a negative error code on failure. > + */ > +int driver_set_override(struct device *dev, char **override, const char *s) > +{
| |