lkml.org 
[lkml]   [2022]   [Feb]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] bus: imx-weim: fix NULL but dereferenced coccicheck error
On Wed, Feb 23, 2022 at 11:51:45AM +0800, Wan Jiabing wrote:
> Fix following coccicheck warning:
> ./drivers/bus/imx-weim.c:355:18-21: ERROR: pdev is NULL but dereferenced.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/bus/imx-weim.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c
> index 60fbd42041dd..2ea0a51f79f6 100644
> --- a/drivers/bus/imx-weim.c
> +++ b/drivers/bus/imx-weim.c
> @@ -352,8 +352,7 @@ static int of_weim_notify(struct notifier_block *nb, unsigned long action,
>
> pdev = of_find_device_by_node(rd->dn);
> if (!pdev) {
> - dev_err(&pdev->dev,
> - "Could not find platform device for '%pOF'\n",
> + pr_err("Could not find platform device for '%pOF'\n",
> rd->dn);
>
> ret = notifier_from_errno(-EINVAL);
> --
> 2.35.1
>

Acked-by: Ivan Bornyakov <i.bornyakov@metrotek.ru>

\
 
 \ /
  Last update: 2022-02-23 08:17    [W:3.756 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site