lkml.org 
[lkml]   [2022]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC RFT PATCH v2 1/2] dt-bindings: mtd: partitions: Document new partition-dynamic nodes
On Tue, Feb 22, 2022 at 12:18:56PM -0600, Rob Herring wrote:
> On Sun, Feb 20, 2022 at 06:39:04PM +0100, Ansuel Smith wrote:
> > Document new partition-dynamic nodes used to provide an OF node for
> > partition registred at runtime by parsers. This is required for nvmem
> > system to declare and detect nvmem-cells.
> >
> > With these special partitions, only the label is required as the parser
> > will provide reg and offset of the mtd. NVMEM will use the data from the
> > parser and provide the NVMEM cells declared in the DTS, "connecting" the
> > dynamic partition with a static declaration of cells in them.
> >
> > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> > ---
> > .../mtd/partitions/partition-dynamic.yaml | 54 +++++++++++++++++++
> > 1 file changed, 54 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/mtd/partitions/partition-dynamic.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/mtd/partitions/partition-dynamic.yaml b/Documentation/devicetree/bindings/mtd/partitions/partition-dynamic.yaml
> > new file mode 100644
> > index 000000000000..945128e754ac
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mtd/partitions/partition-dynamic.yaml
> > @@ -0,0 +1,54 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mtd/partitions/partition-dynamic.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Dynamic Partition
> > +
> > +description: |
> > + This binding describes a single flash partition that is dynamically allocated
> > + by a dedicated parser that is not a fixed-partition parser. To declare a
> > + partition the label is required. This can be used to give a dynamic partition
> > + an OF node so that subsystems like NVMEM can work and provide NVMEM Cells to
>
> 'subsystems like NVMEM' is a Linux detail that shouldn't be in bindings.
>
> > + the system. An example is declaring the partition label and all the NVMEM
> > + cells in it. The parser will detect the correct reg and offset and the NVMEM
> > + will register the cells in it based on the data extracted by the parser.
> > +
> > +maintainers:
> > + - Ansuel Smith <ansuelsmth@gmail.com>
> > +
> > +properties:
> > + label:
> > + description: The label / name for the partition assigned by the parser at
> > + runtime. This is needed for sybsystem like NVMEM to define cells and
> > + register with this OF node.
>
> 'label' is generally for human consumption and should be opaque to the
> OS (or at least the kernel). Perhaps node name should be used like
> Rafał is doing for nvmem[1]. That appears to be the same problem at the
> next level down.
>
> Rob
>
> [1] https://lore.kernel.org/all/20220218070729.3256-1-zajec5@gmail.com/

Ok will add support for node name. Problem is that properties is mandatory
in Documentation and can't be None... so how should I handle this? Keep
label but set it as not required?

--
Ansuel

\
 
 \ /
  Last update: 2022-02-22 19:25    [W:0.060 / U:0.920 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site