lkml.org 
[lkml]   [2022]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH mm] another fix for "kasan: improve vmalloc tests"
On Tue, 22 Feb 2022 at 18:10, <andrey.konovalov@linux.dev> wrote:
>
> From: Andrey Konovalov <andreyknvl@google.com>
>
> set_memory_rw/ro() are not exported to be used in modules and thus
> cannot be used in KUnit-compatible KASAN tests.
>
> Drop the checks that rely on these functions.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
> ---
> lib/test_kasan.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/lib/test_kasan.c b/lib/test_kasan.c
> index ef99d81fe8b3..448194bbc41d 100644
> --- a/lib/test_kasan.c
> +++ b/lib/test_kasan.c
> @@ -1083,12 +1083,6 @@ static void vmalloc_helpers_tags(struct kunit *test)
> KUNIT_ASSERT_TRUE(test, is_vmalloc_addr(ptr));
> KUNIT_ASSERT_NOT_ERR_OR_NULL(test, vmalloc_to_page(ptr));
>
> - /* Make sure vmalloc'ed memory permissions can be changed. */
> - rv = set_memory_ro((unsigned long)ptr, 1);
> - KUNIT_ASSERT_GE(test, rv, 0);
> - rv = set_memory_rw((unsigned long)ptr, 1);
> - KUNIT_ASSERT_GE(test, rv, 0);

You can still test it by checking 'ifdef MODULE'. You could add a
separate test which is skipped if MODULE is defined. Does that work?

\
 
 \ /
  Last update: 2022-02-22 18:51    [W:0.184 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site