lkml.org 
[lkml]   [2022]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] kernel/debug: remove unnecessary CONFIG options
Hi,

On Sun, Feb 20, 2022 at 10:20 PM tangmeng <tangmeng@uniontech.com> wrote:
>
> In kernel/Makefile has:
> obj-$(CONFIG_KGDB) += debug/
>
> so kernel/debug/Makefile don't need this 'obj-$(CONFIG_KGDB) +=',
> delete it from kernel/debug/Makefile.
>
> Signed-off-by: tangmeng <tangmeng@uniontech.com>
> ---
> kernel/debug/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Seems fine to me, with the nit that your Signed-off-by is supposed to
have your "real name", not your username. See
`Documentation/process/submitting-patches.rst`. Some maintainers will
let this slide, but if you're going to submit a patch fixing a nitty
issue then it seems fair to get called out on nits. ;-)

-Doug

\
 
 \ /
  Last update: 2022-02-22 18:30    [W:0.025 / U:0.680 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site