Messages in this thread | | | From | Doug Anderson <> | Date | Tue, 22 Feb 2022 09:30:27 -0800 | Subject | Re: [PATCH] kernel/debug: remove unnecessary CONFIG options |
| |
Hi,
On Sun, Feb 20, 2022 at 10:20 PM tangmeng <tangmeng@uniontech.com> wrote: > > In kernel/Makefile has: > obj-$(CONFIG_KGDB) += debug/ > > so kernel/debug/Makefile don't need this 'obj-$(CONFIG_KGDB) +=', > delete it from kernel/debug/Makefile. > > Signed-off-by: tangmeng <tangmeng@uniontech.com> > --- > kernel/debug/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
Seems fine to me, with the nit that your Signed-off-by is supposed to have your "real name", not your username. See `Documentation/process/submitting-patches.rst`. Some maintainers will let this slide, but if you're going to submit a patch fixing a nitty issue then it seems fair to get called out on nits. ;-)
-Doug
| |