Messages in this thread | | | Date | Tue, 22 Feb 2022 14:30:19 +0000 | Subject | Re: [RFC][PATCH 1/2] dt-bindings: power: add Energy Model bindings | From | Lukasz Luba <> |
| |
Hi Rob,
On 2/22/22 14:22, Rob Herring wrote: > On Mon, 21 Feb 2022 22:51:30 +0000, Lukasz Luba wrote: >> Add DT bindings for the Energy Model information. >> >> Signed-off-by: Lukasz Luba <lukasz.luba@arm.com> >> --- >> .../bindings/power/energy-model.yaml | 51 +++++++++++++++++++ >> 1 file changed, 51 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/power/energy-model.yaml >> > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > ./Documentation/devicetree/bindings/power/energy-model.yaml:34:5: [warning] wrong indentation: expected 2 but found 4 (indentation) > ./Documentation/devicetree/bindings/power/energy-model.yaml:35:8: [warning] wrong indentation: expected 6 but found 7 (indentation) > ./Documentation/devicetree/bindings/power/energy-model.yaml:36:16: [warning] wrong indentation: expected 9 but found 15 (indentation) > ./Documentation/devicetree/bindings/power/energy-model.yaml:35:39: [error] syntax error: expected ',' or '}', but got '{' (syntax) > > dtschema/dtc warnings/errors: > make[1]: *** Deleting file 'Documentation/devicetree/bindings/power/energy-model.example.dts' > Traceback (most recent call last): > File "/usr/local/bin/dt-extract-example", line 46, in <module> > binding = yaml.load(open(args.yamlfile, encoding='utf-8').read()) > File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line 434, in load > return constructor.get_single_data() > File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 119, in get_single_data > node = self.composer.get_single_node() > File "_ruamel_yaml.pyx", line 706, in _ruamel_yaml.CParser.get_single_node > File "_ruamel_yaml.pyx", line 724, in _ruamel_yaml.CParser._compose_document > File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node > File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node > File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node > File "_ruamel_yaml.pyx", line 891, in _ruamel_yaml.CParser._compose_mapping_node > File "_ruamel_yaml.pyx", line 904, in _ruamel_yaml.CParser._parse_next_event > ruamel.yaml.parser.ParserError: while parsing a flow mapping > in "<unicode string>", line 34, column 5 > did not find expected ',' or '}' > in "<unicode string>", line 35, column 39 > make[1]: *** [Documentation/devicetree/bindings/Makefile:25: Documentation/devicetree/bindings/power/energy-model.example.dts] Error 1 > make[1]: *** Waiting for unfinished jobs.... > ./Documentation/devicetree/bindings/power/energy-model.yaml: while parsing a flow mapping > in "<unicode string>", line 34, column 5 > did not find expected ',' or '}' > in "<unicode string>", line 35, column 39 > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/power/energy-model.yaml: ignoring, error parsing file > make: *** [Makefile:1398: dt_binding_check] Error 2 > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/patch/1595776 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. >
This new dt bindings idea is abandoned. We would go for a new entry in the OPP node: "opp-microwatt". I've sent a v2.
BTW, I've tried to run this check, but for some reason my python failed when I tried to upgrade the dtschema:
'Could not find a version that satisfies the requirement jsonschema>=4.1.2 (from dtschema)'
It used to work. I'll probaby have to invest more time and figure out why my pip3 fails.
Regards, Lukasz
| |