lkml.org 
[lkml]   [2022]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] hv_balloon: rate-limit "Unhandled message" warning
    Date
    For a couple of times I have encountered a situation where

    hv_balloon: Unhandled message: type: 12447

    is being flooded over 1 million times per second with various values,
    filling the log and consuming cycles, making debugging difficult.

    Add rate limiting to the message.

    Most other Hyper-V drivers already have similar rate limiting in their
    message callbacks.

    The cause of the floods in my case was probably fixed by 96d9d1fa5cd5
    ("Drivers: hv: balloon: account for vmbus packet header in
    max_pkt_size").

    Fixes: 9aa8b50b2b3d ("Drivers: hv: Add Hyper-V balloon driver")
    Signed-off-by: Anssi Hannula <anssi.hannula@bitwise.fi>
    ---
    drivers/hv/hv_balloon.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c
    index f2d05bff4245..439f99b8b5de 100644
    --- a/drivers/hv/hv_balloon.c
    +++ b/drivers/hv/hv_balloon.c
    @@ -1563,7 +1563,7 @@ static void balloon_onchannelcallback(void *context)
    break;

    default:
    - pr_warn("Unhandled message: type: %d\n", dm_hdr->type);
    + pr_warn_ratelimited("Unhandled message: type: %d\n", dm_hdr->type);

    }
    }
    --
    2.34.1
    \
     
     \ /
      Last update: 2022-02-22 15:23    [W:3.444 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site