Messages in this thread | | | Date | Tue, 22 Feb 2022 12:08:26 +0000 | Subject | Re: [PATCH 09/10] ASoC: codecs: tx-macro: setup soundwire clks correctly | From | Srinivas Kandagatla <> |
| |
On 21/02/2022 16:48, Mark Brown wrote: > On Mon, Feb 21, 2022 at 04:11:56PM +0000, Srinivas Kandagatla wrote: >> On 21/02/2022 15:38, Mark Brown wrote: > >>> A lot of these commit messages sound like earlier patches in the series >>> introduced bugs which isn't going to be ideal for bisection. > >> Yes that is true, I did think about sending this as a fix. > >> Adding a fix tag would not really make any functional difference as we will >> be hitting the issue only when we enable pm runtime in codec and >> SoundWire controller, so I did add this as part of pm runtime patches. > >> Without runtime pm the clocks are left always on, so it worked so far. > > You still need to pull this before you introduce changes that cause > trouble, not after - it needs to be preparation for those other changes. I agree, Will reorder this in next spin.
--srini
| |