Messages in this thread | | | Subject | Re: [PATCH v10 13/18] phy: sun4i-usb: Allow reset line to be shared | From | Samuel Holland <> | Date | Tue, 22 Feb 2022 21:50:48 -0600 |
| |
Hi Andre,
On 2/22/22 9:44 PM, Samuel Holland wrote: > On 2/11/22 6:26 AM, Andre Przywara wrote: >> The USB HCIs (and PHYs?) in Allwinner's newer generation SoCs (H616) >> rely on the reset line of USB PHY 2 to be de-asserted, even when only >> one of the other PHYs is actually in use. > > Thankfully, so far this appears to be a quirk of H616 only. > >> To make those ports work, we include this reset line in the HCIs' resets >> property, which requires this line to be shareable.
Looking at your .dtsi patch 16/18, you don't actually do this. Is this patch not needed anymore?
Regards, Samuel
>> Change the call to allocate the reset line to mark it as shared, to >> enable the other ports on those SoCs. >> >> Signed-off-by: Andre Przywara <andre.przywara@arm.com> >> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> > > Acked-by: Samuel Holland <samuel@sholland.org> >
| |