Messages in this thread | | | Date | Wed, 23 Feb 2022 12:19:49 +0900 | Subject | Re: [PATCH RESEND v2] dm: Fix use-after-free in dm_cleanup_zoned_dev() | From | Damien Le Moal <> |
| |
On 2/23/22 12:02, Mike Snitzer wrote: > On Thu, Feb 17, 2022 at 5:49 AM Damien Le Moal > <damien.lemoal@opensource.wdc.com> wrote: >> >> On 2/17/22 19:13, Kirill Tkhai wrote: >>> >>> dm_cleanup_zoned_dev() uses queue, so it must be called >>> before blk_cleanup_disk() starts its killing: >>> >>> blk_cleanup_disk->blk_cleanup_queue()->kobject_put()->blk_release_queue()-> >>> ->...RCU...->blk_free_queue_rcu()->kmem_cache_free() >>> >>> Otherwise, RCU callback may be executed first, >>> and dm_cleanup_zoned_dev() touches freed memory: >> >> Mike, >> >> Can you queue this please ? > > I queued it earlier today, please see: > https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-5.18&id=588b7f5df0cb64f281290c7672470c006abe7160 > > Thanks, > Mike
Thanks !
-- Damien Le Moal Western Digital Research
| |