Messages in this thread | | | Date | Tue, 22 Feb 2022 00:01:29 -0800 | From | Christoph Hellwig <> | Subject | Re: [PATCH] mesh: Stop using struct scsi_pointer |
| |
On Tue, Feb 22, 2022 at 10:09:42AM +1100, Finn Thain wrote: > This driver doesn't use SCp.ptr to save a SCSI command data pointer > which means "scsi pointer" is a complete misnomer here. Only a few > members of struct scsi_pointer are used and the rest waste memory. > Avoid the "struct foo { struct bar; };" silliness.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |