Messages in this thread | | | Date | Tue, 22 Feb 2022 00:00:12 -0800 | From | Christoph Hellwig <> | Subject | Re: [PATCH] aha152x: Clean up struct scsi_pointer usage |
| |
On Tue, Feb 22, 2022 at 10:09:42AM +1100, Finn Thain wrote: > Bring aha152x into line with 10 other drivers which assign > scsi_host_template.cmd_size = sizeof(struct scsi_pointer) > and avoid the "struct foo { struct bar; };" silliness. > > Remove a pointless scsi_pointer->have_data_in assignment.
I think this going in the wrong direction. The scsi_pointer should go away entirelym and the fields actually used by the driver should move into the aha152x_cmd_priv structure instead.
Same for all other drivers still using the scsi_pointer.
| |