Messages in this thread | | | Date | Tue, 22 Feb 2022 13:12:59 -0800 | From | Keith Busch <> | Subject | Re: [PATCHv3 04/10] linux/kernel: introduce lower_48_bits macro |
| |
On Tue, Feb 22, 2022 at 12:31:30PM -0800, Joe Perches wrote: > > I'd only use something GENMASK() for bit ranges. > > Even then it is often easier to just write the value in hex. > > Mostly it's the count of the repeated f that's difficult to > quickly verify visually.
I admit I made this counting mistake in earlier versions of this series.
I think the earlier suggested "(1ull << 48) - 1" style in an inline function seems good, and it doesn't appear to cause compiler concerns.
| |