Messages in this thread | | | Date | Mon, 21 Feb 2022 15:27:19 +0000 | Subject | Re: [PATCH 01/10] ASoC: codecs: va-macro: add runtime pm support | From | Srinivas Kandagatla <> |
| |
Thanks Mark,
On 21/02/2022 15:24, Mark Brown wrote: > On Mon, Feb 21, 2022 at 01:10:28PM +0000, Srinivas Kandagatla wrote: > >> +static int __maybe_unused va_macro_runtime_resume(struct device *dev) >> +{ >> + struct va_macro *va = dev_get_drvdata(dev); >> + >> + clk_prepare_enable(va->clks[2].clk); > > This magic number stuff is going to be excessively fragile, and the fact
I agree, will try to clean this up properly in next spin.
> that this is sometimes managed via the bulk APIs and sometimes not isn't > going to help either. Either all the clocks should be managed here or > this should be pulled out of the array. > > Also consider error checking. will do,
--srin
| |