lkml.org 
[lkml]   [2022]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 01/10] ASoC: codecs: va-macro: add runtime pm support
From
Thanks Mark,

On 21/02/2022 15:24, Mark Brown wrote:
> On Mon, Feb 21, 2022 at 01:10:28PM +0000, Srinivas Kandagatla wrote:
>
>> +static int __maybe_unused va_macro_runtime_resume(struct device *dev)
>> +{
>> + struct va_macro *va = dev_get_drvdata(dev);
>> +
>> + clk_prepare_enable(va->clks[2].clk);
>
> This magic number stuff is going to be excessively fragile, and the fact

I agree, will try to clean this up properly in next spin.

> that this is sometimes managed via the bulk APIs and sometimes not isn't
> going to help either. Either all the clocks should be managed here or
> this should be pulled out of the array.
>
> Also consider error checking.
will do,

--srin

\
 
 \ /
  Last update: 2022-02-21 19:22    [W:0.037 / U:1.416 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site