Messages in this thread | | | Date | Mon, 21 Feb 2022 11:02:00 +0100 | Subject | Re: [PATCH] iio: adc: xilinx-ams: Use devm_delayed_work_autocancel() to simplify code | From | Michal Simek <> |
| |
Hi,
On 2/20/22 12:45, Jonathan Cameron wrote: > On Sun, 13 Feb 2022 19:29:05 +0100 > Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > >> Use devm_delayed_work_autocancel() instead of hand writing it. This is >> less verbose and saves a few lines of code. >> >> devm_delayed_work_autocancel() uses devm_add_action() instead of >> devm_add_action_or_reset(). This is fine, because if the underlying memory >> allocation fails, no work has been scheduled yet. So there is nothing to >> undo. >> >> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > Looks good to me, but I'd ideally like some input from someone familiar with > the driver.
Anand told me that the change is fine that's why here is my Acked-by: Michal Simek <michal.simek@xilinx.com>
Jonathan: Anand decided to do change in his carrier that's why that emails won't go through. But I am still around if you need something xilinx/amd to test.
Thanks, Michal
| |