lkml.org 
[lkml]   [2022]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 1/5] crypto: sun8i-ss: call finalize with bh disabled
    Date
    Doing ipsec produces a spinlock recursion warning.
    This is due to not disabling BH during crypto completion function.

    Fixes: f08fcced6d00 ("crypto: allwinner - Add sun8i-ss cryptographic offloader")
    Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
    ---
    drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c | 3 +++
    drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c | 3 +++
    2 files changed, 6 insertions(+)

    diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c
    index 9ef1c85c4aaa..554e400d41ca 100644
    --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c
    +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-cipher.c
    @@ -11,6 +11,7 @@
    * You could find a link for the datasheet in Documentation/arm/sunxi.rst
    */

    +#include <linux/bottom_half.h>
    #include <linux/crypto.h>
    #include <linux/dma-mapping.h>
    #include <linux/io.h>
    @@ -274,7 +275,9 @@ static int sun8i_ss_handle_cipher_request(struct crypto_engine *engine, void *ar
    struct skcipher_request *breq = container_of(areq, struct skcipher_request, base);

    err = sun8i_ss_cipher(breq);
    + local_bh_disable();
    crypto_finalize_skcipher_request(engine, breq, err);
    + local_bh_enable();

    return 0;
    }
    diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c
    index d8c333fe5eb2..0c2ca296bede 100644
    --- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c
    +++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c
    @@ -9,6 +9,7 @@
    *
    * You could find the datasheet in Documentation/arm/sunxi.rst
    */
    +#include <linux/bottom_half.h>
    #include <linux/dma-mapping.h>
    #include <linux/pm_runtime.h>
    #include <linux/scatterlist.h>
    @@ -633,6 +634,8 @@ int sun8i_ss_hash_run(struct crypto_engine *engine, void *breq)

    memcpy(areq->result, result, algt->alg.hash.halg.digestsize);
    theend:
    + local_bh_disable();
    crypto_finalize_hash_request(engine, breq, err);
    + local_bh_enable();
    return 0;
    }
    --
    2.34.1
    \
     
     \ /
      Last update: 2022-02-21 19:21    [W:7.387 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site