lkml.org 
[lkml]   [2022]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 8/9] drm/tegra: vic: Implement get_streamid_offset
From
On 2/19/22 20:54, Dmitry Osipenko wrote:
> 19.02.2022 21:49, Dmitry Osipenko пишет:
>> 18.02.2022 14:39, Mikko Perttunen пишет:
>>> +static int vic_get_streamid_offset(struct tegra_drm_client *client)
>>> +{
>>> + struct vic *vic = to_vic(client);
>>> + int err;
>>> +
>>> + err = vic_load_firmware(vic);
>>
>> You can't invoke vic_load_firmware() while RPM is suspended. Either
>> replace this with RPM get/put or do something else.

Why not, I'm not seeing any HW accesses in vic_load_firmware? Although
it looks like it might race with the vic_load_firmware call in
vic_runtime_resume which probably needs to be fixed.

>>
>>> + if (err < 0)
>>> + return err;
>>> +
>>> + if (vic->can_use_context)
>>> + return 0x30;
>>> + else
>>> + return -ENOTSUPP;
>>
>> If (!vic->can_use_context)
>> return -ENOTSUPP;
>>
>> return 0x30;
>
> and s/ENOTSUPP/EOPNOTSUPP/

Ok.

Mikko

\
 
 \ /
  Last update: 2022-02-21 19:21    [W:0.070 / U:0.460 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site